Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up babel messages when testing #5416

Closed
ericsoderberghp opened this issue Jul 2, 2021 · 1 comment · Fixed by #5419
Closed

clean up babel messages when testing #5416

ericsoderberghp opened this issue Jul 2, 2021 · 1 comment · Fixed by #5419

Comments

@ericsoderberghp
Copy link
Member

When running yarn test, the console shows multiple messages like:

The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
	["@babel/plugin-proposal-private-methods", { "loose": false }]
to the "plugins" section of your Babel config.
Though the "loose" option was set to "true" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-methods since the "loose" mode option was set to "false" for @babel/plugin-proposal-class-properties.

These should be addressed.

@ericsoderberghp ericsoderberghp created this issue from a note in Grommet/Design System Backlog (Triage) Jul 2, 2021
@ericsoderberghp ericsoderberghp moved this from Triage to To do in Grommet/Design System Backlog Jul 2, 2021
@halocline halocline self-assigned this Jul 2, 2021
@ericsoderberghp ericsoderberghp moved this from To do to In Review in Grommet/Design System Backlog Jul 6, 2021
@halocline
Copy link
Collaborator

Left a comment on the open PR with my findings: #5419 (comment)

Grommet/Design System Backlog automation moved this from In Review to Done Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants