Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dependencies #5820

Closed

Conversation

britt6612
Copy link
Collaborator

What does this PR do?

Where should the reviewer start?

What testing has been done on this PR?

How should this be manually tested?

Do Jest tests follow these best practices?

  • screen is used for querying.
  • The correct query is used. (Refer to this list of queries)
  • userEvent is used in place of fireEvent.
  • asFragment() is used for snapshot testing.

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Do the grommet docs need to be updated?

Should this PR be mentioned in the release notes?

Is this change backwards compatible or is it a breaking change?

@halocline
Copy link
Collaborator

@britt6612 - I looked into this a bit. I think we are going to have to phase in the dependency upgrades in batches of like updates (as opposed to all at once). The babel dependencies are particularly problematic and it looks like we are going to need to alter configs to accommodate.

Perhaps we can touch base next week?

Also, we should run yarn build && yarn build-storybook to ensure the builds succeed prior to commits.

@britt6612 britt6612 marked this pull request as draft November 29, 2021 20:24
@britt6612
Copy link
Collaborator Author

closing PR going to update in groups for dependencies

@britt6612 britt6612 closed this Nov 29, 2021
@britt6612 britt6612 deleted the November-update-dependencies branch November 29, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants