Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop - remove code for Internet Explorer #6879

Open
jcfilben opened this issue Jul 12, 2023 · 1 comment
Open

Drop - remove code for Internet Explorer #6879

jcfilben opened this issue Jul 12, 2023 · 1 comment
Labels
browser related Associated with browser specific errors needs attention To alert grommet team that a PR has been waiting for the author for a while stale Needs to be re-evaluated to remain current

Comments

@jcfilben
Copy link
Collaborator

Evaluate if we can remove the following block of code from Drop/StyledDrop.js:

  /* IE11 hack to get drop contents to not overflow */
  @media screen and (-ms-high-contrast: active), (-ms-high-contrast: none) {
    display: flex;
    align-items: stretch;
  }

We should be able to remove this since we are no longer supporting internet explorer but we should confirm across browsers (Safari, Chrome, and Firefox) that removing this doesn't have any unexpected consequences.

@jcfilben jcfilben added this to Triage in Grommet/Design System Backlog via automation Jul 17, 2023
@eliasecasta
Copy link

Hello @jcfilben,

I manually tested if there was an issue by removing the code and I couldnt see any, you can check it out from the screenshots that I posted in the pull request, however, a lot of snapshot tests are failing.

@halocline halocline added needs attention To alert grommet team that a PR has been waiting for the author for a while browser related Associated with browser specific errors stale Needs to be re-evaluated to remain current labels Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser related Associated with browser specific errors needs attention To alert grommet team that a PR has been waiting for the author for a while stale Needs to be re-evaluated to remain current
Projects
Development

No branches or pull requests

3 participants