-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add theme option for anchor icon #7236
Conversation
Can we make sure the unit test captures all 4 scenarios listed in the issue? #7198 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
yes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Waiting to merge until after next grommet release |
I updated the branch with master and looks like there are some snapshot issues |
…anchor-icon-color
…grommet into add-anchor-icon-color
fixed |
What does this PR do?
This PR adds in
Anchor.icon.color
Where should the reviewer start?
anchor.js
What testing has been done on this PR?
jest test
How should this be manually tested?
storybook
Do Jest tests follow these best practices?
screen
is used for querying.asFragment()
is used for snapshot testing.Any background context you want to provide?
#7198
What are the relevant issues?
closes #7198
Screenshots (if appropriate)
Do the grommet docs need to be updated?
yes
Should this PR be mentioned in the release notes?
yes
Is this change backwards compatible or is it a breaking change?
backwards compatible