Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example containers - Scrolling issue when using modal layer target #3111

Closed
britt6612 opened this issue Jan 18, 2023 · 0 comments · Fixed by grommet/grommet#6632
Closed

Example containers - Scrolling issue when using modal layer target #3111

britt6612 opened this issue Jan 18, 2023 · 0 comments · Fixed by grommet/grommet#6632
Assignees
@britt6612
Labels
Type:Fix Used in issues for fixing bugs and inconsistencies on existing material.
Projects
Grommet/Design System Backlog

Comments

@britt6612
Copy link
Collaborator

britt6612 commented Jan 18, 2023 •
edited by halocline

More info: The page does not scroll when viewport is at certain widths. Wide or narrow, scrolling occurs; deadzone in between. Related to how the modal layer target is associated with the example container. I notice that when scrolling is functional, the layer appears to leave about 10px; scrolling is not functional when layer is filling the example.

Occurs on Safari, Firefox, and Chrome.

Not scrollable:
Screenshot 2023-01-10 at 5 35 09 PM

Scrollable wide:
Screenshot 2023-01-10 at 5 35 02 PM

Scrollable narrow:
Screenshot 2023-01-10 at 5 33 33 PM

also seen here
@britt6612 britt6612 added the Type:Fix Used in issues for fixing bugs and inconsistencies on existing material. label Jan 18, 2023
@britt6612 britt6612 added this to Triage in Grommet/Design System Backlog via automation Jan 18, 2023
This was referenced Jan 18, 2023
Closed
Merged
@halocline halocline changed the title Scrolling issue when using modal layer target Example containers - Scrolling issue when using modal layer target Jan 18, 2023
@britt6612 britt6612 self-assigned this Feb 1, 2023
@taysea taysea mentioned this issue Feb 9, 2023
Merged
4 tasks
Grommet/Design System Backlog automation moved this from Triage to Done Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@britt6612 britt6612

Labels
Type:Fix Used in issues for fixing bugs and inconsistencies on existing material.
Projects
Grommet/Design System Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change logic for restrict scroll britt6612/grommet
1 participant
@britt6612