Optimise &sha256. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made three changes: - Moved the initialisation of $K outside of the function, since it's a constant for the algorithm. - Some fancy construction (metaops, gather/take) were replaced with more verbose constructions with less overhead. - Array accesses with postcircumfix:<[ ]> were replaced with the lower-level .AT-POS method in the inner loop of the algorithm. Many thanks to timotimo++ for his help with this.
grondilu
added a commit
that referenced
this pull request
Nov 18, 2015
Optimise &sha256. Perfomance matters quite a bit for this module so I'm ok with this, even though I will welcome syntactic simplifications that keep or improve performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on the ipython kernel, I noticed that the HMAC step was taking a while, so I decided to try to optmise the hash function a bit. This is the result.
I made three changes:
constant for the algorithm.
verbose constructions with less overhead.
.AT-POS method in the inner loop of the algorithm.