Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The UDP option not useful without call to s.send() #1

Closed
mhmeadows63 opened this issue Sep 5, 2016 · 2 comments
Closed

The UDP option not useful without call to s.send() #1

mhmeadows63 opened this issue Sep 5, 2016 · 2 comments
Assignees
Labels

Comments

@mhmeadows63
Copy link

mhmeadows63 commented Sep 5, 2016

@grongor
For UDP s.send(...) needed between select.select(...) and s.close(...)

    select.select([s], [s], [s], self.timeout)
+   if self.use_udp: s.send(bytes('', 'utf8'))
    s.close()
@grongor
Copy link
Owner

grongor commented Sep 5, 2016

Yeah, of course, that makes sense. Thank you. I didn't actually test the UDP version - I just quickly put together something that works for my case (all other knock clients failed for some reason). I will soon find some time to test the UDP functionality and then get back to you ;-)

@grongor grongor added the bug label Sep 5, 2016
@grongor grongor self-assigned this Sep 5, 2016
@mhmeadows63
Copy link
Author

mhmeadows63 commented Sep 5, 2016

No problem, yours is the only one I found with IPv6 support and it also works with link-local addresses having a %<interface> suffix.

My UDP fix suggestion is working fine for me on both IPv4 and IPv6.

@grongor grongor mentioned this issue Sep 6, 2016
@grongor grongor closed this as completed in #2 Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants