Skip to content

Commit

Permalink
Change hash of options destructively in parse_XXX methods in "table_c…
Browse files Browse the repository at this point in the history
…reate" command
  • Loading branch information
Kosuke Asami committed Jul 11, 2013
1 parent a23a662 commit 83324f8
Showing 1 changed file with 7 additions and 9 deletions.
16 changes: 7 additions & 9 deletions lib/droonga/plugin/groonga/table_create.rb
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,14 @@ def execute(request)
private
def parse_request(request)
options = {}
options.merge!(parse_flags(request))
options.merge!(parse_key_type(request))
options.merge!(parse_value_type(request))
parse_flags(options, request)
parse_key_type(options, request)
parse_value_type(options, request)
options
end

def parse_flags(request)
options = {:type => :hash}
def parse_flags(options, request)
options[:type] = :hash
if request["flags"]
request["flags"].split(/\|/).each do |flag|
case flag
Expand All @@ -66,14 +66,12 @@ def parse_flags(request)
options
end

def parse_key_type(request)
options = {}
def parse_key_type(options, request)
options[:key_type] = request["key_type"] if request["key_type"]
options
end

def parse_value_type(request)
options = {}
def parse_value_type(options, request)
options[:value_type] = request["value_type"] if request["value_type"]
options
end
Expand Down

0 comments on commit 83324f8

Please sign in to comment.