Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate that this project is deprecated and has been replaced by gmaven-plus #4

Closed
mattraibert opened this issue Oct 15, 2017 · 7 comments

Comments

@mattraibert
Copy link

I was confused into installing this outdated project. It would be a good idea to indicate that there is a replacement.

@jdillon
Copy link
Member

jdillon commented Oct 15, 2017

gmaven-plus has not really placed gmaven, the author of gmaven-plus just descided to go in another direction and didn't want to work together>

@keeganwitt
Copy link
Member

GMaven 2 and GMavenPlus have different goals. GMaven 2 is focused on script execution, GMavenPlus is kinda a continuation of GMaven's original goals. GMaven 1 isn't actively maintained anymore, but GMaven 2 is.

I think Jason felt Groovy-Eclipse Maven Plugin was a better option for compilation (and it does have the advantage that it doesn't use stubs), but there were things I disliked about it, which I tried to impartially (perhaps unsuccessfully) describe here. One bit of good news is that it looks like @eric-milles has been working on Groovy-Eclipse which has needed contributors for a while.

In retrospect, I kinda regret my naming choice as it comes across as somewhat adversarial, which was not my intent.

@jdillon
Copy link
Member

jdillon commented Oct 16, 2017

@keeganwitt I appreciate your feed back. I haven't looked at the state of compilation for a while and it was frustrating at best to work with the Groovy folks. FTR I have no objections to gmaven-plus for users that need it, yes I think it was a poor project name and confused lots of folks, but thats life.

I am still using and maintaining GMaven 2.x as a purge scripting integration into Maven. I long since gave up on the complexity to maintain sane compilation as as you mention for the most part just use the groovy-eclipse-compiler; but that itself seems to be pretty out of date.

@jdillon
Copy link
Member

jdillon commented Oct 16, 2017

but ftr the project isn't dead its slow maybe I'm busy with a lot of other things and honestly it just works. Folks looking for just adding Groovy scripting to Maven its still very viable. I'm still not sure there is any sane compilation solution sans the groovy-eclipse-compiler, but honestly I've not looked to hard; as it works well enough for everything I use it for.

@mattraibert
Copy link
Author

Oh I see! Thanks for all the info.

Perhaps the fix is to add a link to the GMaven 2 branch or switch master over then? Current master (where you land from google or from the github.io page) shows a branch/README that hasn't been updated since 2012. Now that I've found the 2.0 branch I'm gonna give the project another try!

@jdillon
Copy link
Member

jdillon commented Oct 16, 2017

Sure yes, maybe time to flip the default branch; and/or branch for 1.x and merge 2.x down to master.

@jdillon
Copy link
Member

jdillon commented Jul 18, 2018

default branch is now gmaven-2.x, will change it to master in a bit, previous master is gmaven-1.x now.

@jdillon jdillon closed this as completed Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants