Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Removing book animations (at least on mobile) #39

Closed
grantmcconnaughey opened this issue Jul 21, 2014 · 4 comments
Closed

Removing book animations (at least on mobile) #39

grantmcconnaughey opened this issue Jul 21, 2014 · 4 comments

Comments

@grantmcconnaughey
Copy link
Contributor

The book animations are neat, but I think removing them should be considered, at the very least on mobile.

On a mobile device, they break the layout and slow scrolling to a grinding halt. Now that links to the books are included for each book (via the orange book title header) there is no more need to include the "More Info" link.

On desktop I don't have a huge problem with them, except for maybe that the book cover is hidden when the book opens. There aren't really any performance issues I've noticed, though.

@glaforge and @melix, what are your thoughts?

@melix
Copy link
Member

melix commented Jul 21, 2014

It's not that slow on my mobile, so I didn't notice, but yes, I agree that they should be disabled on mobile devices.

@glaforge
Copy link
Member

We could probably try and see if we can remove the animation under a certain screen size.
Perhaps under 768px where the description of the book goes below the book itself.

@grantmcconnaughey
Copy link
Contributor Author

Submitted a PR for this.

@glaforge
Copy link
Member

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants