New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstract configuration #3
Comments
Thanks for creating this ticket. We should definitely get as much specific information out of the code as possible and we should do it in small incremental steps. @jamescr will like the json format above as that looks very similar to what he is already using in his fork. How about we start with extracting the |
Sounds good! |
I put the basic configuration into a separate json config file. It's in the recent pull request. I appreciate your consideration! |
Thanks a lot! Btw., there's no need to mention this here again. I get notified about new PRs and changes to them ;) |
👍 for using a json file for the config data., I'll comment on the PR. |
Hello,
currently a lot of custom configuration data is stored in code. I'd like to push it to be more generic.
I'd suggest to rely on a config.json file similar to geom2gtfs does: https://github.com/conveyal/geom2gtfs/blob/master/kingco.json.example
We could start with a simple structure, based on the general information used for querying from OSM and from GTFS' agency.txt and start and end date from calendar.txt:
What do you think? Is this a way to go?
The text was updated successfully, but these errors were encountered: