Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError comparing dates #48

Closed
jamescr opened this issue Dec 5, 2016 · 1 comment
Closed

TypeError comparing dates #48

jamescr opened this issue Dec 5, 2016 · 1 comment

Comments

@jamescr
Copy link
Collaborator

jamescr commented Dec 5, 2016

If the json config file includes in the feed info only one of the dates: "start_date" or "end_date" then the other is generated automatically. But when this happen the object type for the generated date is datetime.date and the type of the date from config file is datetime.datetime. When the dates validation is done an TypeError occurs: «can't compare datetime.datetime to datetime.date»

This could be fixed using datetime.datetime in both cases. I'll create a PR is you agree.

@grote
Copy link
Owner

grote commented Dec 9, 2016

I am not too familiar with that code, but what you describe does sound like a bug to me.

Fenix uses completely automatic dates, so it seems not to be affected by that.

@grote grote closed this as completed in bc8e74a Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants