Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade transitfeed library and remove feed_info workaround #90

Closed
grote opened this issue Nov 29, 2017 · 6 comments
Closed

Upgrade transitfeed library and remove feed_info workaround #90

grote opened this issue Nov 29, 2017 · 6 comments

Comments

@grote
Copy link
Owner

grote commented Nov 29, 2017

google/transitfeed#394 has been merged and released as 1.2.16.The workaround in the code to add the feed_info.txt manually should be removed now.

Also, Accra regression tests need to be fixed. There are different stop times now.

@grote
Copy link
Owner Author

grote commented Jan 24, 2018

A new version has been released: https://pypi.python.org/pypi/transitfeed

The work-around should be removed now and we should depend on the latest version.

@grote grote changed the title Remove feed_info workaround Upgrade transitfeed library and remove feed_info workaround Jan 24, 2018
@grote
Copy link
Owner Author

grote commented Jan 24, 2018

@nlehuby or @prhod when you get a chance, could you please look into why the transitfeed upgrade changes your gtfs zip and maybe package a new one for now?

@prhod
Copy link
Collaborator

prhod commented Jan 25, 2018

HI @grote ! I'll try to have a look soon. Note to self : only the stop_times.txt file is different.

@prhod
Copy link
Collaborator

prhod commented Jan 26, 2018

Looking further, I have differences in stop_times. For example, trip_id 82 takes 15' from end to end and the expected travel time is 2 hours. I still need to investigate.

@prhod
Copy link
Collaborator

prhod commented Jan 27, 2018

I don't know why I had differencies before, I don't have anymore. Maybe I mixed up my working files ...
Anyway, I made the PR #122 to upgrade to the last version of Transitland. The only difference was the addition of the "timepoint" column in the stop_times.txt file.

@xamanu
Copy link
Contributor

xamanu commented Mar 1, 2018

The associated PR has been merged. Can this issue be closed, @grote? Thanks!

@grote grote closed this as completed Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants