Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GRDBCustomSQLite to GRDB for compatibility with dependents? #743

Closed
mallman opened this issue Mar 28, 2020 · 3 comments
Closed

Rename GRDBCustomSQLite to GRDB for compatibility with dependents? #743

mallman opened this issue Mar 28, 2020 · 3 comments
Milestone

Comments

@mallman
Copy link
Collaborator

mallman commented Mar 28, 2020

Would you mind elaborating on why GRDB with a custom SQLite build has a different module name from the ordinary GRDB? I ask because there is a major practical problem with the current convention. As-is, no framework that imports "GRDB" (e.g. GRDBCombine) is source compatible with GRDBCustomSQLite. Yet I don't understand why the underlying implementation of SQLite should be reflected in the module name, as long as the underlying code is API-compatible.

Even in my app's source code, I don't see a reason it needs to know whether I'm linking against the implementation of GRDB with the standard SQLite build or an implementation with a custom SQLite build—except for where I'm using the custom interface. But shouldn't those differences be restricted to the smallest possible API surface area?

@groue
Copy link
Owner

groue commented Mar 29, 2020

Hello @mallman,

This name was picked in #62 and was not changed since.

GRDBCipher was eventually renamed to GRDB in v4.0.0.

Well, GRDBCustomSQLite will be renamed to GRDB in v5.0.0, all right 👍

You can check #718 for the progress.

@groue groue added this to the GRDB 5 milestone Mar 29, 2020
This was referenced Mar 29, 2020
@groue
Copy link
Owner

groue commented Apr 12, 2020

Fixed in #747 and #756

@groue
Copy link
Owner

groue commented May 2, 2020

Fixed in v5.0.0-beta

@groue groue closed this as completed May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants