Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leaks #14

Closed
njdehoog opened this issue Oct 21, 2015 · 10 comments
Closed

Memory leaks #14

njdehoog opened this issue Oct 21, 2015 · 10 comments

Comments

@njdehoog
Copy link

Hey @groue, it's me again ;) Have you ever noticed any memory leaks in the framework? I have some memory leaks in my app, and when I use Instruments to track down the leak, it seems to point to GRMustache as the source:

screen shot 2015-10-21 at 16 24 00

I spent a bunch of time trying to figure out what could be the root cause, and if maybe I was doing something wrong that would cause this issue, but I can't figure it out. Do you have any ideas maybe?

@groue
Copy link
Owner

groue commented Oct 21, 2015

Oops. Let me check.

@njdehoog
Copy link
Author

Note that I can't reproduce the issue in the sample app.

@groue
Copy link
Owner

groue commented Oct 21, 2015

I may have to ask you some sample code. We're not there yet.

@njdehoog
Copy link
Author

I was afraid you were gonna said that ;) I'll see if I can isolate the problem in a sample project. This might take a while...

@groue
Copy link
Owner

groue commented Oct 21, 2015

Don't do it now, let me try to reproduce first!

@njdehoog
Copy link
Author

Too late. I've copied some stuff over from my project and I was able to reproduce the issue. Try profiling the OS X demo app and you should see the memory leaks after rendering.

Here's the debug project:
https://www.dropbox.com/s/inttwlrhqgde2z3/GRMustache.swift.zip?dl=0

@groue
Copy link
Owner

groue commented Oct 21, 2015

Thanks Niels :-) OK I'm looking at that very soon. Hold on!

@njdehoog
Copy link
Author

Sounds good 👍 Let me know if I can help.

@groue
Copy link
Owner

groue commented Oct 24, 2015

Thanks for your sample code, I can reproduce the leak. It's pretty tricky, actually! Still investigating :-)

@groue
Copy link
Owner

groue commented Oct 23, 2016

@njdehoog I have good reasons to think that these leaks come from Swift itself. I expect them to vanish with Swift 3.

@groue groue closed this as completed Oct 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants