Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-root version #54

Closed
alexsteeel opened this issue Jul 6, 2022 · 5 comments
Closed

Add non-root version #54

alexsteeel opened this issue Jul 6, 2022 · 5 comments

Comments

@alexsteeel
Copy link
Contributor

Is it possible to add a version with non-root user?

@groundnuty
Copy link
Owner

@alexsteeel Sure, I guess it could a default. I can't imagine what could running everything as regular user break (I'm just not sure what are permissions of the token mounted inside tho).

I don't have a proper secure k8s cluster on my hands to test it properly. So fell free to create a PR that with the modifications that would satisfy your use-case.

@alexsteeel
Copy link
Contributor Author

@groundnuty I added pull-request #55, but I haven't worked with travis, so I'm not sure about my solution.
I checked docker image on my local kubernetes cluster with

  securityContext:
	runAsNonRoot: true

in deployment for init container. It works.

@alexsteeel
Copy link
Contributor Author

alexsteeel commented Jul 7, 2022

I tested with curl without version, not curl=7.80.0-r1. With curl=7.80.0-r1 I have error as in CI job.

Update: I changed version from 7.80.0-r1 to 7.80.0-r2, it's ok.

@groundnuty
Copy link
Owner

@alexsteeel in the end duplication of Dockerfile did not sit well with me I refactored it in 6d103dc I hope it still fulfils your usecase

@alexsteeel
Copy link
Contributor Author

@groundnuty ok, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants