Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core-rx and core-rx2 have class name collision when used in same project #42

Closed
chenthorne opened this issue May 25, 2018 · 2 comments
Closed

core-rx and core-rx2 have class name collision when used in same project #42

chenthorne opened this issue May 25, 2018 · 2 comments

Comments

@chenthorne
Copy link
Contributor

Surprising as it may sound, I have a project with RxJava1/Grox Rx1 in one module, and RxJava2/Grox Rx2 in another. They work fine on their own, but when bringing them together, there's a collision as grox-core-rx and grox-core-rx2 use the same package and class name.

Most libraries solve this evolution problem by namespacing the Rx related classes under rx1 or rx2. Would this be something Grox would be willing to support?
@chenthorne chenthorne mentioned this issue May 25, 2018
Merged
@chenthorne
Copy link
Contributor Author

@alin-turcu any idea when this will be available in a release?

@alin-turcu
Copy link
Collaborator

@chenthorne Grox 1.1.2 has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alin-turcu @chenthorne