Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to more recent upstream? #165

Closed
mkeeter opened this issue Jan 19, 2021 · 2 comments · Fixed by #166
Closed

Update to more recent upstream? #165

mkeeter opened this issue Jan 19, 2021 · 2 comments · Fixed by #166

Comments

@mkeeter
Copy link

mkeeter commented Jan 19, 2021

I recently ran into this issue when writing code using wgpu-native.

Any interest in updating the spirv_cross crate to the most recent upstream? I'm happy to test whether a simple submodule bump works, or whether more of the API has changed.

Pushing the fix all the way downstream to wgpu-native is going to be a challenge, as I think it goes through

  • spirv_cross
  • gfx backends
  • gfx-hal proper
  • wgpu-core
  • wgpu-native

But having an updated spirv_cross is the first step!

@grovesNL
Copy link
Owner

Sure, no problem. I just published 0.23 because there were some small breaking changes since the last release. We could've managed a patch release for spirv_cross, but it's useful to get the breaking changes into gfx anyway.

We currently pin wgpu-core's master branch to git commits of gfx and regularly update it, so we can probably propagate this to wgpu-native's master branch pretty quickly.

@mkeeter
Copy link
Author

mkeeter commented Jan 20, 2021

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants