Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(link, button): cursor is 'not-allowed' when disabled and loading #1373

Merged
merged 4 commits into from
Oct 21, 2021

Conversation

nnmax
Copy link
Contributor

@nnmax nnmax commented Oct 21, 2021

No description provided.

@vercel
Copy link

vercel bot commented Oct 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/8TjJPnqQ9Bwpe6dAksaXHYbdHH2o
✅ Preview: https://gio-design-git-buttonandlinkdisabledcursornotallowed-growingio.vercel.app

@nnmax nnmax changed the title Button and link disabled cursor not allowed fix(link, button): cursor is 'not-allowed' when disabled and loading Oct 21, 2021
@@ -35,13 +36,6 @@ const Button = React.forwardRef<HTMLButtonElement, ButtonProps>((props, ref) =>

const suffixIcon = suffix && <span className={`${prefixCls}-suffix-icon`}>{suffix}</span>;

const disabled = disabledProp || loading;

const other: typeof restProps = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原生 button 标签已经自带 AIRA 了,不需要再添加

className={classes}
ref={ref}
aria-disabled={disabled}
tabIndex={disabled ? -1 : 0}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disabled 时,禁止使用 tab 访问

@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

29.4% 29.4% Coverage
0.0% 0.0% Duplication

@nnmax nnmax merged commit b128824 into master Oct 21, 2021
@nnmax nnmax deleted the buttonAndLinkDisabledCursorNotAllowed branch October 21, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants