-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(link, button): cursor is 'not-allowed' when disabled and loading #1373
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/growingio/gio-design/8TjJPnqQ9Bwpe6dAksaXHYbdHH2o |
@@ -35,13 +36,6 @@ const Button = React.forwardRef<HTMLButtonElement, ButtonProps>((props, ref) => | |||
|
|||
const suffixIcon = suffix && <span className={`${prefixCls}-suffix-icon`}>{suffix}</span>; | |||
|
|||
const disabled = disabledProp || loading; | |||
|
|||
const other: typeof restProps = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
原生 button 标签已经自带 AIRA 了,不需要再添加
className={classes} | ||
ref={ref} | ||
aria-disabled={disabled} | ||
tabIndex={disabled ? -1 : 0} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disabled 时,禁止使用 tab 访问
Kudos, SonarCloud Quality Gate passed! |
No description provided.