Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(popover): refactor offset and add offset attribute #1538

Merged
merged 1 commit into from
Nov 27, 2021
Merged

fix(popover): refactor offset and add offset attribute #1538

merged 1 commit into from
Nov 27, 2021

Conversation

berber1016
Copy link
Contributor

@berber1016 berber1016 commented Nov 27, 2021 •
edited

  1. new offset attribute
  2. inputButton 去除外层span (由于外层span高度会导致一些问题)
  3. 根据offset来设置上下左右距离
  4. visible 使用 useControledValue来控制

@vercel
Copy link

vercel bot commented Nov 27, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/8nnMSZfSaH11WhEttUmR9jezqDm3
✅ Preview: https://gio-design-git-fix-bug-growingio.vercel.app

@sonarcloud
Copy link

sonarcloud bot commented Nov 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@zzt1224 zzt1224 merged commit 6c4044c into master Nov 27, 2021
@zzt1224 zzt1224 deleted the fix-bug branch November 27, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzt1224 zzt1224 zzt1224 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@berber1016 @zzt1224