Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(style): clear up all trigger style controls #1543

Merged
merged 1 commit into from
Nov 29, 2021
Merged

fix(style): clear up all trigger style controls #1543

merged 1 commit into from
Nov 29, 2021

Conversation

berber1016
Copy link
Contributor

@berber1016 berber1016 commented Nov 29, 2021

  1. listPicker
  2. select
  3. casacder

整理了以上这些 组件 有关 trigger的样式控制,让控制起来的难度更小一些

  • 移除 triggerProps 参数 将 style, className, allowClear, prefix, suffix, hidePrefix,title,placeholder拿出,需要各位配合着改一下有关这里样式的问题。
  • inputButton 统一包装一层div, 可在组件内部使用 style、className样式来覆盖
  • 综合考虑 将 inputButton 的ref修正在 新包装的div上,用来解决popover根据ref定位时,偏移问题

各类trigger样式控制:
跟随父级宽度 style={{width:'100%'}}
自动宽(不需要设定宽度)
自定义宽度 style={{width:'240px'}}

二:

  1. select 新增 allowWith 自动设置 content宽度 与 原有select保持一致
  2. 修复 tooltip allow 小三角指向问题
  3. list新增 onClick 方法
  4. Input 组件重新定义ref指向

@vercel
Copy link

vercel bot commented Nov 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/2tVx9QEkm2UBgUxbG3yZd27aRXo6
✅ Preview: https://gio-design-git-fix-bug-growingio.vercel.app

@sonarcloud
Copy link

sonarcloud bot commented Nov 29, 2021

Please retry analysis of this Pull-Request directly on SonarCloud.

1. listPicker select cascader 重新定义triggerProps
2. select 新增 allowWith 自动设置 content宽度 与 原有select保持一致
3. 修复 tooltip allow 小三角指向问题
4. list新增 onClick 方法
5. Input 组件重新定义ref指向
@sonarcloud
Copy link

sonarcloud bot commented Nov 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@berber1016 berber1016 merged commit f90a38c into master Nov 29, 2021
@berber1016 berber1016 deleted the fix-bug branch November 29, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants