Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list-picker): fix list-picker empty error #1600

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Conversation

berber1016
Copy link
Contributor

@berber1016 berber1016 commented Dec 2, 2021

empty 判断规则:当下层 Item 没有任何一个的时候,则会判断为empty

需要注意的是:
现在无法判断empty是这种结构

<selection>{(context) => { /** some code */}}</selection>

@vercel
Copy link

vercel bot commented Dec 2, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/2zXKGxaaQyzuVZiXVBYsRwumQ8z3
✅ Preview: https://gio-design-git-list-picker-growingio.vercel.app

@berber1016 berber1016 changed the title fix(list-picker): fix list-picker empty error fix(list-picker): fix list-picker empty error(逻辑还未写完 暂不合并) Dec 3, 2021
@sonarcloud
Copy link

sonarcloud bot commented Dec 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@berber1016 berber1016 changed the title fix(list-picker): fix list-picker empty error(逻辑还未写完 暂不合并) fix(list-picker): fix list-picker empty error Dec 3, 2021
@berber1016 berber1016 merged commit f37fbed into master Dec 3, 2021
@berber1016 berber1016 deleted the list-picker branch December 3, 2021 07:14
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2021

🎉 This PR is included in version 22.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants