fix(list-picker): fix list-picker demo #1678

berber1016 · 2021-12-15T04:32:08Z

No description provided.

vercel · 2021-12-15T04:32:12Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/3g2X27z4fUgJ698PCk83Kgb6ftWa
✅ Preview: https://gio-design-git-fix-list-picker-growingio.vercel.app

codeclimate · 2021-12-15T04:32:53Z

src/list-picker/demos/List-picker.stories.tsx

        </Tabs.Tab>
-        <Tabs.Tab value="" label="访问属性">
-          <List.Selection options={searchData2().reverse()} />
+        <Tabs.Tab value="visit" label="访问属性">


Similar blocks of code found in 4 locations. Consider refactoring.

codeclimate · 2021-12-15T04:32:53Z

src/list/Item.tsx

@@ -33,7 +35,17 @@ export const InnerItem = WithRef<HTMLLIElement, ItemProps>((props, ref?) => {
      />
    );
  }
-  return <BaseItem ref={ref} data-testid="list-item-base" label={label} value={value} disabled={disabled} {...rest} />;
+  return (


Similar blocks of code found in 2 locations. Consider refactoring.

semgrep-app · 2021-12-15T04:33:19Z

src/list/Item.tsx

+    <BaseItem
+      key={value}
+      ref={ref}
+      data-testid="list-item-base"
+      label={label}
+      value={value}
+      disabled={disabled}
+      {...rest}
+    />


ref usage found, refs give direct DOM access and may create a possibility for XSS

Click a link below to tell your Security Team if this comment was:
👍 useful
👎 not useful (false positive)
🤔 confusing

^{This comment is advisory. You do not need to address it before merging this pull request.}
(typescript.react.security.audit.react-no-refs.react-no-refs from Rule board)

semgrep-app · 2021-12-15T04:33:23Z

src/list/Item.tsx

+    <BaseItem
+      key={value}
+      ref={ref}
+      data-testid="list-item-base"
+      label={label}
+      value={value}
+      disabled={disabled}
+      {...rest}
+    />


It is a good practice to avoid spreading for JSX attributes. This forces the code to be explicit about which props are given to the component. This avoids situations where warnings are caused by invalid HTML props passed to HTML elements, and further, it avoids passing unintentional extra props by malicious actors. Instead, consider explicitly passing props to the component.

Click a link below to tell your Security Team if this comment was:
👍 useful
👎 not useful (false positive)
🤔 confusing

^{This comment is advisory. You do not need to address it before merging this pull request.}
(typescript.react.best-practice.react-props-spreading.react-props-spreading from Rule board)

semgrep-app · 2021-12-15T04:33:31Z

Semgrep was unable to comment inline on the following findings:

In src/list/Item.tsx:14-22

It is a good practice to avoid spreading for JSX attributes. This forces the code to be explicit about which props are given to the component. This avoids situations where warnings are caused by invalid HTML props passed to HTML elements, and further, it avoids passing unintentional extra props by malicious actors. Instead, consider explicitly passing props to the component.

Click a link below to tell your Security Team if this comment was:
👍 useful
👎 not useful (false positive)
🤔 confusing

In src/list/Item.tsx:27-35

ref usage found, refs give direct DOM access and may create a possibility for XSS

Click a link below to tell your Security Team if this comment was:
👍 useful
👎 not useful (false positive)
🤔 confusing

In src/list-picker/Trigger.tsx:43-53

It is a good practice to avoid spreading for JSX attributes. This forces the code to be explicit about which props are given to the component. This avoids situations where warnings are caused by invalid HTML props passed to HTML elements, and further, it avoids passing unintentional extra props by malicious actors. Instead, consider explicitly passing props to the component.

Click a link below to tell your Security Team if this comment was:
👍 useful
👎 not useful (false positive)
🤔 confusing

In src/list/Item.tsx:14-22

ref usage found, refs give direct DOM access and may create a possibility for XSS

Click a link below to tell your Security Team if this comment was:
👍 useful
👎 not useful (false positive)
🤔 confusing

In src/list/Item.tsx:27-35

It is a good practice to avoid spreading for JSX attributes. This forces the code to be explicit about which props are given to the component. This avoids situations where warnings are caused by invalid HTML props passed to HTML elements, and further, it avoids passing unintentional extra props by malicious actors. Instead, consider explicitly passing props to the component.

Click a link below to tell your Security Team if this comment was:
👍 useful
👎 not useful (false positive)
🤔 confusing

In src/select/Select.tsx:95-113

ref usage found, refs give direct DOM access and may create a possibility for XSS

Click a link below to tell your Security Team if this comment was:
👍 useful
👎 not useful (false positive)
🤔 confusing

In src/list-picker/demos/List-picker.stories.tsx:468-493

It is a good practice to avoid spreading for JSX attributes. This forces the code to be explicit about which props are given to the component. This avoids situations where warnings are caused by invalid HTML props passed to HTML elements, and further, it avoids passing unintentional extra props by malicious actors. Instead, consider explicitly passing props to the component.

Click a link below to tell your Security Team if this comment was:
👍 useful
👎 not useful (false positive)
🤔 confusing

In src/list-picker/Trigger.tsx:43-53

ref usage found, refs give direct DOM access and may create a possibility for XSS

Click a link below to tell your Security Team if this comment was:
👍 useful
👎 not useful (false positive)
🤔 confusing

^{How do I suppress this?}

semgrep-app · 2021-12-15T04:33:31Z

src/list-picker/listPicker.tsx

    ...rest
  } = props;
  const defaultPrefix = usePrefixCls(prefixCls);
  const [visible, setVisible] = useControlledState(controlledVisible, false);
  const [value, setValue] = useState(controlledValue || defaultValue);
  const { options, setOptions, getOptionByValue, getLabelByValue, getOptionsByValue } = useCacheOptions();
-
+  const triggerRef = useRef<HTMLInputElement | undefined>(undefined);


ref usage found, refs give direct DOM access and may create a possibility for XSS

Click a link below to tell your Security Team if this comment was:
👍 useful
👎 not useful (false positive)
🤔 confusing

^{This comment is advisory. You do not need to address it before merging this pull request.}
(typescript.react.security.audit.react-no-refs.react-no-refs from Rule board)

semgrep-app · 2021-12-15T05:37:55Z

Semgrep was unable to comment inline on the following findings:

In src/list-picker/demos/List-picker.stories.tsx:469-494

It is a good practice to avoid spreading for JSX attributes. This forces the code to be explicit about which props are given to the component. This avoids situations where warnings are caused by invalid HTML props passed to HTML elements, and further, it avoids passing unintentional extra props by malicious actors. Instead, consider explicitly passing props to the component.

Click a link below to tell your Security Team if this comment was:
👍 useful
👎 not useful (false positive)
🤔 confusing

^{How do I suppress this?}

semgrep-app · 2021-12-15T05:44:45Z

src/list/Item.tsx

  }
-  return <BaseItem ref={ref} data-testid="list-item-base" label={label} value={value} disabled={disabled} {...rest} />;
+  return <BaseItem {...defaultProps} data-testid="list-item-base" />;


It is a good practice to avoid spreading for JSX attributes. This forces the code to be explicit about which props are given to the component. This avoids situations where warnings are caused by invalid HTML props passed to HTML elements, and further, it avoids passing unintentional extra props by malicious actors. Instead, consider explicitly passing props to the component.

Click a link below to tell your Security Team if this comment was:
👍 useful
👎 not useful (false positive)
🤔 confusing

^{This comment is advisory. You do not need to address it before merging this pull request.}
(typescript.react.best-practice.react-props-spreading.react-props-spreading from Rule board)

semgrep-app · 2021-12-15T05:44:46Z

src/list/Item.tsx

-        {...rest}
-      />
-    );
+    return <CheckboxItem {...defaultProps} data-testid="list-item-checkbox" />;


It is a good practice to avoid spreading for JSX attributes. This forces the code to be explicit about which props are given to the component. This avoids situations where warnings are caused by invalid HTML props passed to HTML elements, and further, it avoids passing unintentional extra props by malicious actors. Instead, consider explicitly passing props to the component.

Click a link below to tell your Security Team if this comment was:
👍 useful
👎 not useful (false positive)
🤔 confusing

^{This comment is advisory. You do not need to address it before merging this pull request.}
(typescript.react.best-practice.react-props-spreading.react-props-spreading from Rule board)

semgrep-app · 2021-12-15T05:44:46Z

src/list/Item.tsx

-        {...rest}
-      />
-    );
+    return <CalcaderItem {...(defaultProps as any)} data-testid="list-item-cascader" />;


It is a good practice to avoid spreading for JSX attributes. This forces the code to be explicit about which props are given to the component. This avoids situations where warnings are caused by invalid HTML props passed to HTML elements, and further, it avoids passing unintentional extra props by malicious actors. Instead, consider explicitly passing props to the component.

Click a link below to tell your Security Team if this comment was:
👍 useful
👎 not useful (false positive)
🤔 confusing

^{This comment is advisory. You do not need to address it before merging this pull request.}
(typescript.react.best-practice.react-props-spreading.react-props-spreading from Rule board)

codeclimate · 2021-12-20T03:34:40Z

Code Climate has analyzed commit 1f40d30 and detected 0 issues on this pull request.

View more on Code Climate.

sonarcloud · 2021-12-20T03:38:27Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

# [22.8.0](v22.7.0...v22.8.0) (2021-12-20) ### Bug Fixes * **input:** fix input console ([#1696](#1696)) ([7879bb4](7879bb4)) * **list-picker:** fix list-picker demo ([#1678](#1678)) ([a38017f](a38017f)) * **list:** support empty ([#1682](#1682)) ([c1500f6](c1500f6)) * **page:** fix page storybook and collapse parameters not show ([#1684](#1684)) ([b138552](b138552)) * **past-time-picker:** fix active style ([#1700](#1700)) ([c3c718c](c3c718c)) * **select:** fix select model prop error ([#1702](#1702)) ([a40b4a4](a40b4a4)) * **upload:** fix upload reSelect not invoke model ([#1698](#1698)) ([292f45a](292f45a)) ### Features * **dropdown:** set active status on Button or IconButton when visible ([#1697](#1697)) ([33d72d5](33d72d5)) * **link:** support `component` prop ([#1699](#1699)) ([0bb93f0](0bb93f0))

jack0pan · 2021-12-20T11:14:35Z

🎉 This PR is included in version 22.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

codeclimate bot reviewed Dec 15, 2021

View reviewed changes

semgrep-app bot reviewed Dec 15, 2021

View reviewed changes

berber1016 force-pushed the fix-list-picker branch from ff04bfd to 5a0bcac Compare December 15, 2021 05:36

vercel bot deployed to Preview December 15, 2021 05:36 View deployment

berber1016 requested a review from zhuzilv December 15, 2021 05:37

berber1016 force-pushed the fix-list-picker branch from 5a0bcac to 7fe8d34 Compare December 15, 2021 05:43

vercel bot deployed to Preview December 15, 2021 05:43 View deployment

semgrep-app bot reviewed Dec 15, 2021

View reviewed changes

zhuzilv approved these changes Dec 15, 2021

View reviewed changes

fix(list-picker): fix list-picker demo

1f40d30

berber1016 force-pushed the fix-list-picker branch from 7fe8d34 to 1f40d30 Compare December 20, 2021 03:33

vercel bot deployed to Preview December 20, 2021 03:34 View deployment

berber1016 merged commit a38017f into master Dec 20, 2021

berber1016 deleted the fix-list-picker branch December 20, 2021 03:36

jack0pan added the released label Dec 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(list-picker): fix list-picker demo #1678

fix(list-picker): fix list-picker demo #1678

berber1016 commented Dec 15, 2021

vercel bot commented Dec 15, 2021 •

edited

codeclimate bot Dec 15, 2021

codeclimate bot Dec 15, 2021

semgrep-app bot Dec 15, 2021

semgrep-app bot Dec 15, 2021

semgrep-app bot commented Dec 15, 2021

semgrep-app bot Dec 15, 2021

semgrep-app bot commented Dec 15, 2021

semgrep-app bot Dec 15, 2021

semgrep-app bot Dec 15, 2021

semgrep-app bot Dec 15, 2021

codeclimate bot commented Dec 20, 2021

sonarcloud bot commented Dec 20, 2021

jack0pan commented Dec 20, 2021

fix(list-picker): fix list-picker demo #1678

fix(list-picker): fix list-picker demo #1678

Conversation

berber1016 commented Dec 15, 2021

vercel bot commented Dec 15, 2021 • edited

codeclimate bot Dec 15, 2021

Choose a reason for hiding this comment

codeclimate bot Dec 15, 2021

Choose a reason for hiding this comment

semgrep-app bot Dec 15, 2021

Choose a reason for hiding this comment

semgrep-app bot Dec 15, 2021

Choose a reason for hiding this comment

semgrep-app bot commented Dec 15, 2021

In src/list/Item.tsx:14-22

In src/list/Item.tsx:27-35

In src/list-picker/Trigger.tsx:43-53

In src/list/Item.tsx:14-22

In src/list/Item.tsx:27-35

In src/select/Select.tsx:95-113

In src/list-picker/demos/List-picker.stories.tsx:468-493

In src/list-picker/Trigger.tsx:43-53

semgrep-app bot Dec 15, 2021

Choose a reason for hiding this comment

semgrep-app bot commented Dec 15, 2021

In src/list-picker/demos/List-picker.stories.tsx:469-494

semgrep-app bot Dec 15, 2021

Choose a reason for hiding this comment

semgrep-app bot Dec 15, 2021

Choose a reason for hiding this comment

semgrep-app bot Dec 15, 2021

Choose a reason for hiding this comment

codeclimate bot commented Dec 20, 2021

sonarcloud bot commented Dec 20, 2021

jack0pan commented Dec 20, 2021

vercel bot commented Dec 15, 2021 •

edited