fix(cascader): add itemPosition attr #1689
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/growingio/gio-design/3FfsU4KbrGLNqjedXH3D8sqsMXPx |
|
Code Climate has analyzed commit 2b459a9 and detected 0 issues on this pull request. View more on Code Climate. |
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
| <Item {...option} strategy={itemStrategy} key={option.value}> | ||
| {renderedItem} | ||
| </Item> |
There was a problem hiding this comment.
It is a good practice to avoid spreading for JSX attributes. This forces the code to be explicit about which props are given to the component. This avoids situations where warnings are caused by invalid HTML props passed to HTML elements, and further, it avoids passing unintentional extra props by malicious actors. Instead, consider explicitly passing props to the component.
Click a link below to tell your Security Team if this comment was:
👍 useful
👎 not useful (false positive)
🤔 confusing
This comment is advisory. You do not need to address it before merging this pull request.
(typescript.react.best-practice.react-props-spreading.react-props-spreading from Rule board)
In src/list/Item.tsx:26-34It is a good practice to avoid spreading for JSX attributes. This forces the code to be explicit about which props are given to the component. This avoids situations where warnings are caused by invalid HTML props passed to HTML elements, and further, it avoids passing unintentional extra props by malicious actors. Instead, consider explicitly passing props to the component. Click a link below to tell your Security Team if this comment was: In src/cascader/Cascader.tsx:113-124It is a good practice to avoid spreading for JSX attributes. This forces the code to be explicit about which props are given to the component. This avoids situations where warnings are caused by invalid HTML props passed to HTML elements, and further, it avoids passing unintentional extra props by malicious actors. Instead, consider explicitly passing props to the component. Click a link below to tell your Security Team if this comment was: In src/list/Item.tsx:26-34
Click a link below to tell your Security Team if this comment was:
How do I suppress this?
|
|
Kudos, SonarCloud Quality Gate passed! |
# [22.7.0](v22.6.0...v22.7.0) (2021-12-16) ### Bug Fixes * **cascader:** add itemPosition attr ([#1689](#1689)) ([b554264](b554264)) * **input-button:** fix input button active style ([#1679](#1679)) ([1f11cce](1f11cce)) * **popover:** add popover flip ([#1690](#1690)) ([513ee54](513ee54)) * **popover:** fixed popover flip ([#1692](#1692)) ([f062748](f062748)) * **property-picker:** 修改属性选择器分类导航使用新的tabs,可左右滑动 ([#1695](#1695)) ([b6508e0](b6508e0)) ### Features * **list:** add event param in the onClick ([#1693](#1693)) ([0feb381](0feb381)) * **popover:** support onContentClick event ([#1691](#1691)) ([6d8fef2](6d8fef2))
|
🎉 This PR is included in version 22.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.