Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(list): add event param in the onClick #1693

Merged
merged 1 commit into from
Dec 16, 2021
Merged

feat(list): add event param in the onClick #1693

merged 1 commit into from
Dec 16, 2021

Conversation

nnmax
Copy link
Contributor

@nnmax nnmax commented Dec 16, 2021

No description provided.

@vercel
Copy link

vercel bot commented Dec 16, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/B7e3xKg7dFApprmuEuVe9tJPwyAc
✅ Preview: https://gio-design-git-listitemonclickevent-growingio.vercel.app

@codeclimate
Copy link

codeclimate bot commented Dec 16, 2021

Code Climate has analyzed commit 75f1761 and detected 0 issues on this pull request.

View more on Code Climate.

@semgrep-app
Copy link

semgrep-app bot commented Dec 16, 2021

Semgrep was unable to comment inline on the following findings:

In src/list/inner/CascaderItem.tsx:102-115

ref usage found, refs give direct DOM access and may create a possibility for XSS

Click a link below to tell your Security Team if this comment was:
👍 useful
👎 not useful (false positive)
🤔 confusing

In src/list/inner/CascaderItem.tsx:102-115

It is a good practice to avoid spreading for JSX attributes. This forces the code to be explicit about which props are given to the component. This avoids situations where warnings are caused by invalid HTML props passed to HTML elements, and further, it avoids passing unintentional extra props by malicious actors. Instead, consider explicitly passing props to the component.

Click a link below to tell your Security Team if this comment was:
👍 useful
👎 not useful (false positive)
🤔 confusing

How do I suppress this?

@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@nnmax nnmax merged commit 0feb381 into master Dec 16, 2021
@nnmax nnmax deleted the ListItemOnClickEvent branch December 16, 2021 09:15
jack0pan pushed a commit that referenced this pull request Dec 16, 2021
@semantic-release-bot
chore(release): version 22.7.0 changelog
65c6a32 
# [22.7.0](v22.6.0...v22.7.0) (2021-12-16)

### Bug Fixes

* **cascader:** add itemPosition attr ([#1689](#1689)) ([b554264](b554264))
* **input-button:** fix input button active style ([#1679](#1679)) ([1f11cce](1f11cce))
* **popover:** add popover flip ([#1690](#1690)) ([513ee54](513ee54))
* **popover:** fixed popover flip ([#1692](#1692)) ([f062748](f062748))
* **property-picker:** 修改属性选择器分类导航使用新的tabs,可左右滑动 ([#1695](#1695)) ([b6508e0](b6508e0))

### Features

* **list:** add event param in the onClick ([#1693](#1693)) ([0feb381](0feb381))
* **popover:** support onContentClick event ([#1691](#1691)) ([6d8fef2](6d8fef2))
@jack0pan
Copy link
Member

🎉 This PR is included in version 22.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berber1016 berber1016 berber1016 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nnmax @jack0pan @berber1016