[Bug] Global Webhooks do not report all possible SDK payload changes

[dlemaigl]

Summary

The Global Playbooks documentation states that the webhook is triggered when the SDK payload changes, but there are some cases where this is not the case, like when the user changes the SDK to be encrypted. Creations and deletions are also not notified.

Expected Behavior

All operations that change, create, or delete SDKs in any way should be notified

Current Behavior

Only a subset of operations like feature flag changes are notified.

[august-growthbook]

Hi @jdorn did the PR that closed this issue include creations and deletions of SDK Connections? The person who submitted this issue (@dlemaigl) says the creation and deletion is still not included.

[jdorn]

Yes, this should have been fixed by this line in the PR: https://github.com/growthbook/growthbook/pull/2533/files#diff-f309a8a4f4821ef9e4a16b37dd6bbdf990b6eed36cd436bff2605ada341a20ecR76

If the bug is still happening, can you include steps to reproduce along with the build version/date you are running?

[dlemaigl]

Hi @jdorn,

I am testing version a502b5d, the last one from today. The steps to reproduce the bug are the following:

1. Configure a Global Webhook -> WEBHOOKS=[{"url":"http://XXXXX","sendPayload":true}]
2. Create a FF
3. Create an SDK. The Global webhook will not be triggered
4. Change the value of the FF, The GW will be triggered
5. Delete the SDK. The GW will not be triggered

[august-growthbook]

@dlemaigl We just merged a fix for this: #2592

Please let me know if you are still seeing any issues.

[dlemaigl]

@august-growthbook, now it triggers correctly on create SDK but when deleting the SDK it does not trigger it