-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use protobuf v1.0.0 instead of master #126
Comments
Yeah, I don't know what their policy is. Hopefully with |
It would be very nice to fix this -- especially with other projects having that constraint, you can quickly run into
|
@mwitkow ive actually been thinking of removing dep and dependancy management from the project ... is an ongoing discussion im having offline with @Bplotka about wether we should even include this for libraries / packages 😄 |
Yea, I am not fan of non-std deps for library, but we have lots of it that are unavoidable, so maybe using dep mngt is actually must-have to ensure users see with what deps we tested against. First of all before changing anything... Can we do some releases? |
@srenatus, since protobuf 1.0.0 did not change any API we use vs our used version, have you try to use https://golang.github.io/dep/docs/Gopkg.toml.html#override in your Gopkg.toml for protobuf to avoid these errors? |
@Bplotka Thank you. That's another option indeed. 👍 |
Hello there, since #40 is now closed and we have a tagged release, can we match the version in |
I assume this error is related to this issue:
|
I was thinking... would removal of dep and moving to Go modules would help ? |
Switching to |
Switching to ^1.0.0 or anything that supports using a constraint on 1.2.0 would be really helpful - I'm having trouble introducing this dependency as well |
|
@bwplotka there're still many projects that use dep. |
I am not sure if dep is still relevant 4 years later, so closing. |
Since about 2 weeks ago there is a tagged release for golang/protobuf. It would probably make sense to use this as the constraint in the Gopkg file instead of master.
https://github.com/golang/protobuf/releases
The text was updated successfully, but these errors were encountered: