Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in field extractor (splices -> slices) #287

Merged
merged 1 commit into from Apr 28, 2020
Merged

Fix typo in field extractor (splices -> slices) #287

merged 1 commit into from Apr 28, 2020

Conversation

bvwells
Copy link
Contributor

@bvwells bvwells commented Apr 27, 2020

No description provided.

@codecov-io
Copy link

codecov-io commented Apr 27, 2020

Codecov Report

Merging #287 into master will increase coverage by 0.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
+ Coverage   73.27%   73.77%   +0.49%     
==========================================
  Files          42       42              
  Lines        1564     1590      +26     
==========================================
+ Hits         1146     1173      +27     
  Misses        365      365              
+ Partials       53       52       -1     
Impacted Files Coverage Δ
tags/fieldextractor.go 85.29% <ø> (ø)
tracing/opentracing/id_extract.go 85.18% <0.00%> (-5.73%) ⬇️
retry/retry.go 76.24% <0.00%> (-1.11%) ⬇️
auth/metadata.go 100.00% <0.00%> (ø)
retry/options.go 80.48% <0.00%> (ø)
recovery/interceptors.go 100.00% <0.00%> (ø)
logging/zap/ctxzap/context.go 0.00% <0.00%> (ø)
logging/zap/client_interceptors.go 100.00% <0.00%> (ø)
logging/zap/server_interceptors.go 100.00% <0.00%> (ø)
logging/logrus/client_interceptors.go 100.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c51f7f...2ced0e6. Read the comment docs.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Could you cherry pick this against v2 as well?

@johanbrandhorst johanbrandhorst merged commit b4e7e96 into grpc-ecosystem:master Apr 28, 2020
@bvwells
Copy link
Contributor Author

bvwells commented Apr 29, 2020

@johanbrandhorst thanks for the review and merge. I've opened up a PR on the V2 branch with the cherry picked commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants