-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc_logrus: Use FieldLogger #52
Comments
gTBH it's relatively easy to pass in an What are the benefitsof |
It's an interface fulfilled by |
Sounds sensible. Wanna submit a PR? :) |
Sure, but don't know when I will find some time to do so, so feel free to pick it if you want. |
I started to take a stab at this, but the payload interceptor expects to be able to access the
It might be possible to return a |
This is pretty old and we know have |
Haven't checked the code yet, but I saw in the documentation that the logrus middleware awaits a
logrus.Entry
. Wouldn't it be better to rely on thelogrus.FieldLogger
interface?The text was updated successfully, but these errors were encountered: