Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test: examples/internal/integration/integration_test.go:TestTimeout #1527

Closed
johanbrandhorst opened this issue Jul 16, 2020 · 1 comment 路 Fixed by #2247
Closed

Flaky test: examples/internal/integration/integration_test.go:TestTimeout #1527

johanbrandhorst opened this issue Jul 16, 2020 · 1 comment 路 Fixed by #2247
Labels
bug good first issue help wanted

Comments

@johanbrandhorst
Copy link
Collaborator

馃悰 Bug Report

The TestTimeout test is sometimes failing randomly.

To Reproduce

$ go test -run TestTimeout -count 100 ./examples/internal/integration

Expected behavior

Test not to be flaky

Actual Behavior

The tests fails with an incorrect status code error:

integration_test.go:1395: resp.StatusCode = 500; want 504

See https://app.circleci.com/pipelines/github/grpc-ecosystem/grpc-gateway/993/workflows/f7328257-19fe-436c-8cd4-8f2274bcb535/jobs/13566.
@johanbrandhorst johanbrandhorst mentioned this issue Jul 16, 2020
Merged
2 tasks
@Tamiraltshuler Tamiraltshuler mentioned this issue Jul 24, 2021
Merged
@Tamiraltshuler
Copy link
Contributor

Tamiraltshuler commented Jul 24, 2021 •
edited

Hey,
first time contributor made a pr #2247 to fix this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(integ-test): timeout test is now consistent Tamiraltshuler/grpc-gateway
2 participants
@johanbrandhorst @Tamiraltshuler