New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why the rctx is substituted by a new empty context? #788

Closed

curelyreas opened this issue Oct 25, 2018 · 1 comment

curelyreas commented Oct 25, 2018

grpc-gateway/protoc-gen-grpc-gateway/gengateway/template.go

Line 427 in ab0345b

rctx, err := runtime.AnnotateContext(ctx, mux, req)

It breaks the life cycle of a request information delivery.

Collaborator

johanbrandhorst commented Oct 25, 2018

This only adds things to the existing context, see the signature of runtime.AnnotateContext: https://github.com/grpc-ecosystem/grpc-gateway/blob/master/runtime/context.go#L59

johanbrandhorst closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment