Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please release the repo, IOReaderFactory is not available on the latest release! #823

Closed
moorara opened this issue Dec 7, 2018 · 2 comments

Comments

@moorara
Copy link

moorara commented Dec 7, 2018

The IOReaderFactory on github.com/grpc-ecosystem/grpc-gateway/utilities is not available on latest release (1.5.1). As a result, when using dependency manager tools like dep, a generated *.pb.gw.go file cannot be compiled.

@johanbrandhorst
Copy link
Collaborator

This is only true if you don't version the generator together with the runtime library. If you're using dep it will mean adding it as a required dependency and installing from vendor:

required = [
    "github.com/grpc-ecosystem/grpc-gateway-boilerplate/protoc-gen-grpc-gateway"
]
$ go install ./vendor/github.com/grpc-ecosystem/grpc-gateway-boilerplate/protoc-gen-grpc-gateway

@johanbrandhorst
Copy link
Collaborator

That said, we do need a release. I will close this though since it's not really an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants