Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose service availability to actuator #110

Closed
ST-DDT opened this issue Oct 24, 2018 · 4 comments · Fixed by #285
Closed

Expose service availability to actuator #110

ST-DDT opened this issue Oct 24, 2018 · 4 comments · Fixed by #285
Assignees
@ST-DDT
Labels
enhancement A feature request or improvement
Milestone
2.6.0

Comments

@ST-DDT
Copy link
Collaborator

ST-DDT commented Oct 24, 2018

It would be nice, if clients would report offline/online services to the actuator health endpoint.

The same also applies to the server, but the grpc library does not yet expose that value to other beans:
grpc/grpc-java#4992

I'm not sure, whether/when I can PR that feature.
@ST-DDT ST-DDT added enhancement A feature request or improvement on hold Currently no progress possible labels Nov 27, 2018
@ST-DDT
Copy link
Collaborator Author

ST-DDT commented Nov 29, 2018

Waiting for upstream changes

@ST-DDT ST-DDT self-assigned this Nov 29, 2018
@asarkar
Copy link

asarkar commented Aug 1, 2019 •
edited
Loading

I'm new to gRPC, and this project, but curious how would "offline/online" status be determined? Channel ConnectivityState?

@ST-DDT
Copy link
Collaborator Author

ST-DDT commented Aug 2, 2019

That might work for the client-side. I need to take a closer look at this.

@ST-DDT ST-DDT added this to the 2.6.0 milestone Aug 22, 2019
@ST-DDT ST-DDT removed the on hold Currently no progress possible label Aug 22, 2019
@ST-DDT
Copy link
Collaborator Author

ST-DDT commented Aug 22, 2019

Might be useful in combination with spring-projects/spring-boot#14022
(aka not getting your application killed if a grpc client is unable to connect)

@ST-DDT ST-DDT mentioned this issue Sep 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ST-DDT ST-DDT

Labels
enhancement A feature request or improvement
Projects
None yet
Milestone
2.6.0
Development

Successfully merging a pull request may close this issue.

Expose channel connectivity to actuator grpc-ecosystem/grpc-spring
2 participants
@asarkar @ST-DDT