Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for zookeeper service discovery #474

Closed
ZMRWEGO opened this issue Jan 5, 2021 · 5 comments · Fixed by #475
Closed

Add support for zookeeper service discovery #474

ZMRWEGO opened this issue Jan 5, 2021 · 5 comments · Fixed by #475
Labels
enhancement A feature request or improvement
Milestone
2.11.0

Comments

@ZMRWEGO
Copy link
Contributor

ZMRWEGO commented Jan 5, 2021 •
edited

The middlewares maintained by our team are zk and etcd, which seem to be unsupported at present.
I wrote a zk metadata config based on your current version here. Let me see if it can be incorporated.
@ZMRWEGO ZMRWEGO added the enhancement A feature request or improvement label Jan 5, 2021
@ZMRWEGO
Copy link
Contributor Author

ZMRWEGO commented Jan 5, 2021 •
edited

I use spring-cloud-starter-zookeeper-discoveryin combination with grpc-server-spring-boot-starter, the scene should be similar to consul.

@ZMRWEGO ZMRWEGO changed the title 目前没有支持zk注册中心马上 Currently there is no support for zk registration center, do you plan to join in the future Jan 5, 2021
@ST-DDT
Copy link
Collaborator

ST-DDT commented Jan 5, 2021

Sounds like a good addition.
I'm not that familiar with the cloud discovery registrations, but I hope to find a way to generically support all discovery implementations eventually.
Until then we have to add them individually.

Contributions are always welcome.

@ZMRWEGO
Copy link
Contributor Author

ZMRWEGO commented Jan 6, 2021

Now I have unified the existing registration centers, and the verification is ok. I will submit a merge request to you to review at night

@ST-DDT ST-DDT linked a pull request Jan 8, 2021 that will close this issue
增加zookeeper注册中心，统一各注册中心写法 #475
Merged
@ST-DDT
Copy link
Collaborator

ST-DDT commented Jan 8, 2021

FFR #475

@ZMRWEGO
Copy link
Contributor Author

ZMRWEGO commented Jan 11, 2021

is every thing ok

@ST-DDT ST-DDT changed the title Currently there is no support for zk registration center, do you plan to join in the future Add support for zookeeper service discovery Jan 11, 2021
@ST-DDT ST-DDT added this to the 2.11.0 milestone Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A feature request or improvement
Projects
None yet
Milestone
2.11.0
Development

Successfully merging a pull request may close this issue.

增加zookeeper注册中心，统一各注册中心写法 ZMRWEGO/grpc-spring-boot-starter
2 participants
@ST-DDT @ZMRWEGO