Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Windows version when using WinHttpHandler #2226

Closed
JamesNK opened this issue Aug 3, 2023 · 1 comment · Fixed by #2229
Closed

Validate Windows version when using WinHttpHandler #2226

JamesNK opened this issue Aug 3, 2023 · 1 comment · Fixed by #2229
Labels
enhancement New feature or request

Comments

@JamesNK
Copy link
Member

JamesNK commented Aug 3, 2023

#2220 adds a net462 target and automatically wires up WinHttpHandler.

WinHttpHandler has some Windows version requirements. Constructing a channel should throw an error if WinHttpHandler is used on unsupported versions of Windows.

Note: on Windows Server 2022 there is partial support for WinHttpHandler. Unary and server streaming calls succeed, client and bidi streaming calls fail. Channel shouldn't throw an error on Windows Server 2022 to not block people who only need unary on Win2022.

Related: #2197

@jskeet
Copy link

jskeet commented Aug 3, 2023

For the "note": I understand the motivation here, and not throwing is probably the right call - but it would be really useful to have some way of detecting this without each user having to write the Windows Server 2022 detection code. (Perhaps something in GrpcChannelOptions to indicate which features are required, and throw if they're not all met? I'm not sure how feasible that is.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants