Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StreamDesc passed to NewClientStream() contains fields only applicable to servers #1827

Closed
dfawley opened this issue Jan 24, 2018 · 0 comments · Fixed by #4397
Closed

StreamDesc passed to NewClientStream() contains fields only applicable to servers #1827

dfawley opened this issue Jan 24, 2018 · 0 comments · Fixed by #4397
Assignees
@dfawley
Labels
fixit P2 Type: Documentation Documentation or examples

Comments

@dfawley
Copy link
Member

dfawley commented Jan 24, 2018

This appears to have been done as a convenience in order to reuse the same StreamDesc that we use to register handlers. Users don't want to be confused by undocumented fields that don't even apply.

I'll document them for now, but we should do something different in a newer API.
@dfawley dfawley added Type: API Change Breaking API changes (experimental APIs only!) P2 v2 labels Jan 24, 2018
@dfawley dfawley self-assigned this May 3, 2021
@dfawley dfawley added fixit Type: Documentation Documentation or examples and removed Type: API Change Breaking API changes (experimental APIs only!) labels May 3, 2021
@dfawley dfawley mentioned this issue May 7, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dfawley dfawley

Labels
fixit P2 Type: Documentation Documentation or examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

grpc: improve docs on StreamDesc dfawley/grpc-go
1 participant
@dfawley