Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2_client is missing tests #2248

Open
jeanbza opened this issue Jul 31, 2018 · 3 comments
Open

http2_client is missing tests #2248

jeanbza opened this issue Jul 31, 2018 · 3 comments

Comments

@jeanbza
Copy link
Member

jeanbza commented Jul 31, 2018

The following cases are untested, and should be tested:

e.g. changes in #2219 were almost merged that should not have because of lack of the aforementioned test coverage.

@stale stale bot added the stale label Sep 6, 2019
@dfawley dfawley removed the stale label Sep 6, 2019
@grpc grpc deleted a comment from stale bot May 4, 2021
@menghanl menghanl added P3 and removed P2 labels May 4, 2021
@easwars easwars self-assigned this May 17, 2022
@easwars easwars removed their assignment Nov 16, 2022
@v-sreejith
Copy link

@ginayeh I would like to contribute here

@arvindbr8
Copy link
Member

Sure! Assigning it to you.

The original issue description might not be relevant anymore. I would re-evaluate the missed coverage of the file here.

@arvindbr8
Copy link
Member

@v-sreejith -- ping.. Are you still actively tracking this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants