Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed UnimplementedFooService in every service #3069

Closed
dfawley opened this issue Oct 3, 2019 · 1 comment
Closed

Embed UnimplementedFooService in every service #3069

dfawley opened this issue Oct 3, 2019 · 1 comment

Comments

@dfawley
Copy link
Member

dfawley commented Oct 3, 2019

This should include: examples, tests, benchmarks, and most importantly: reflection, interop, channelz, health, etc.

@dfawley
Copy link
Member Author

dfawley commented Oct 11, 2019

We will leave reflection, health, channelz, interop, etc, alone in order to notice when new methods are added. We wish to always implement all methods and can tolerate build breakages.

This is only acceptable because our repo is the canonical source of the generated proto files for golang. If the protos were maintained elsewhere, a build breakage could occur when users referenced a later version of the protos than our repo.

@dfawley dfawley closed this as completed Oct 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant