New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service config: allow default method config #3473

Closed

menghanl opened this issue Mar 25, 2020 · 0 comments · Fixed by #3684

Labels

P2 Type: Feature

Contributor

menghanl commented Mar 25, 2020 •

edited

Ignore methodConfig entries with no name instead of failing.
For the service and method fields in the methodConfig name, treat null and empty string as unset instead of failing.
Add support for a methodConfig that specifies the default for all services and all methods.
Reject the config if there are multiple methodConfig entries with the same name.

grpc/grpc-proto#75
grpc/grpc#22232

menghanl added P2 Type: Feature labels

menghanl self-assigned this

dfawley assigned GarrettGutierrez1 and unassigned menghanl

amenzhinsky mentioned this issue

service config: add default method config support #3684

Merged

menghanl unassigned GarrettGutierrez1

menghanl closed this as completed in #3684

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.