Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regenerate.sh: include standard protos; update generated files #4177

Merged
merged 1 commit into from Jan 28, 2021

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Jan 27, 2021

  • Pull in protobuf repo since one of our protos pulls in duration.proto
  • Update grpc_testing/messages.pb.go to pull in a recent change

- Pull in protobuf repo since one of our protos pulls in duration.proto
- Update grpc_testing/messages.pb.go to pull in a recent change
@easwars
Copy link
Contributor Author

easwars commented Jan 27, 2021

vet-proto fails because of the change in interop/grpc_testing/messages.pb.go.

When I tried to fix it by running regenerate.sh, it was failing saying it could not find duration.proto. I was under the impression that it was earlier in googleapis repo (not sure though). So, I added the protobuf package to pull in duration.proto.

@dfawley dfawley changed the title grpc: Update protobuf regenerate script regenerate.sh: include standard protos; update generated files Jan 27, 2021
@easwars easwars merged commit 7bb497f into grpc:master Jan 28, 2021
@easwars easwars deleted the update_proto branch January 28, 2021 00:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants