Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc: delete deprecated dial option WithBalancerName #5229

Closed
easwars opened this issue Mar 8, 2022 · 4 comments · Fixed by #5232 or #5555
Closed

grpc: delete deprecated dial option WithBalancerName #5229

easwars opened this issue Mar 8, 2022 · 4 comments · Fixed by #5232 or #5555
Assignees
Labels
Type: API Change Breaking API changes (experimental APIs only!)

Comments

@easwars
Copy link
Contributor

easwars commented Mar 8, 2022

WithBalancerName has been marked deprecated for years. Deleting this will clean up some code paths, leading to simpler and more maintainable code.

@easwars easwars added the Type: API Change Breaking API changes (experimental APIs only!) label Mar 8, 2022
@easwars easwars self-assigned this Mar 8, 2022
@easwars
Copy link
Contributor Author

easwars commented Mar 23, 2022

#5232 deleted the API, but looks like there are still some internal users who are using this API, and we might have to re-add this in some limited fashion.

@easwars
Copy link
Contributor Author

easwars commented Mar 30, 2022

We have taken care of this internally. Closing this.

@easwars easwars closed this as completed Mar 30, 2022
@dfawley dfawley reopened this Jul 12, 2022
@dfawley
Copy link
Member

dfawley commented Jul 12, 2022

This was rolled back, but is (mostly) ready to go again.

@dfawley
Copy link
Member

dfawley commented Jul 12, 2022

Looks like my memory was hazy. We did not roll this back. However, there is a lingering reference to WithBalancerName that should be cleaned up here:

// LB is the load balancer the service providers recommends. The balancer
// specified via grpc.WithBalancerName will override this. This is deprecated;
// lbConfigs is preferred. If lbConfig and LB are both present, lbConfig
// will be used.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: API Change Breaking API changes (experimental APIs only!)
Projects
None yet
2 participants