Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: check type_url field of typed_config for extensions instead of the legacy name field #5659

Open
easwars opened this issue Sep 17, 2022 · 1 comment

Comments

@easwars
Copy link
Contributor

easwars commented Sep 17, 2022

Currently, there are two extensions that we need to care about:

  • the TransportSocket extension where we check for name field to be envoy.transport_sockets.tls, and
  • the custom cluster type extension where we check for name field to be envoy.clusters.aggregate

In both these cases we need to instead check the type_url field inside of the typed_config.

See related C-core change for the same grpc/grpc#31024

@easwars
Copy link
Contributor Author

easwars commented Sep 19, 2022

There could be more, we probably need to do an audit and check for pretty much any Any field. Another way to scan for it is any protobuf that we use whose name starts with envoy.extensions.

@easwars easwars added the fixit label Sep 19, 2022
@dfawley dfawley added the P2 label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants