Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance stub balancer API to be able to wrap a real balancer underneath #5683

Open
easwars opened this issue Oct 4, 2022 · 0 comments
Open
Labels
fixit P2 Type: Feature New features or improvements in behavior

Comments

@easwars
Copy link
Contributor

easwars commented Oct 4, 2022

We have a bunch of repeated code in our tests where we have a test balancer implementation which wraps a real balancer, because some behavior like creation of subConns once addresses are pushed to the balancer are required in the test. The test balancer would also be doing some other things like pushing some events on the channel.

We could get rid of all this repeated/duplicate code if we can get the stub balancer to support a real balancer underneath, along with its existing functionality.

https://github.com/grpc/grpc-go/blob/master/internal/balancer/stub/stub.go

@easwars easwars added the Type: Feature New features or improvements in behavior label Oct 4, 2022
@zasweq zasweq added the P2 label Oct 11, 2022
@easwars easwars added the fixit label Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixit P2 Type: Feature New features or improvements in behavior
Projects
None yet
Development

No branches or pull requests

2 participants