Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support string matcher for header matching in RBAC. #6369

Closed
zasweq opened this issue Jun 13, 2023 · 0 comments · Fixed by #6419
Closed

Support string matcher for header matching in RBAC. #6369

zasweq opened this issue Jun 13, 2023 · 0 comments · Fixed by #6419
Assignees
Labels
Type: Feature New features or improvements in behavior
Milestone

Comments

@zasweq
Copy link
Contributor

zasweq commented Jun 13, 2023

Java and C share Header Matcher code between RBAC and xDS (used in the route table). Thus, other languages do support string matching for header matching in RBAC. gRPC-Go currently does not:

func newHeaderMatcher(headerMatcherConfig *v3route_componentspb.HeaderMatcher) (*headerMatcher, error) {
. Alongside supporting string matching, we should look into trying to share header matching code between xDS and RBAC like other languages (or perhaps there was a technical reason we decided not to).

@zasweq zasweq added the Type: Feature New features or improvements in behavior label Jun 13, 2023
@zasweq zasweq self-assigned this Jun 13, 2023
@zasweq zasweq added this to the 1.57 Release milestone Jun 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant