resolver: remove deprecated AddressType #6451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
added
the
Type: API Change
|
Fix vet failure: Also, I don't see a deletion of the |
Whoops. I had deleted it, but I put it back later and forgot to remove it again. Also forgot to add |
easwars
approved these changes
Jul 14, 2023
| @@ -114,6 +115,7 @@ func (b *pickfirstBalancer) UpdateClientConnState(state balancer.ClientConnState | |||
| } | |||
|
|
|||
| if envconfig.PickFirstLBConfig && b.cfg != nil && b.cfg.ShuffleAddressList { | |||
| addrs = append([]resolver.Address{}, addrs...) | |||
There was a problem hiding this comment.
This is nice. Didn't know this trick before. I would have written this as a two-liner with a make and copy.
KnutZuidema
added a commit
to KnutZuidema/kuberesolver
that referenced
this pull request
Sep 19, 2023
The type attribute has been removed in more recent versions of gRPC. The usage here is not required and the may be removed. See: grpc/grpc-go#6451
KnutZuidema
added a commit
to KnutZuidema/kuberesolver
that referenced
this pull request
Sep 19, 2023
The type attribute has been removed in more recent versions of gRPC. The usage here is not required and the may be removed. See: grpc/grpc-go#6451
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor clean-up ahead of the upcoming dual-stack changes.
RELEASE NOTES:
balancer/grpclb/state.Set()should be used to add these addresses to the name resolver's output. The built-in "dns" name resolver already does this.