Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename weighted_round_robin_experimental into weighted_round_robin #6476

Closed
atollena opened this issue Jul 25, 2023 · 3 comments
Closed

Rename weighted_round_robin_experimental into weighted_round_robin #6476

atollena opened this issue Jul 25, 2023 · 3 comments
Assignees
Labels
P2 Type: Feature New features or improvements in behavior

Comments

@atollena
Copy link
Collaborator

atollena commented Jul 25, 2023

The weighted_round_robin balancer name has the experimental suffix in Golang, so that it must be referred to as weighted_round_robin_experimental. Java (code) and C-core (code) both use weighted_round_robin without the suffix. The predefined oneof in service config protobuf definition also uses weighted_round_robin (code). As a result, services that wish to use weighted_round_robin in Go have to use a service config loadBalancerConfig of the form:

loadBalancerConfig: [
  {
    name: "weighted_round_robin"
  },
  {
    name: "weighted_round_robin_experimental"
  }
]

and duplicate the parameters.

This issue tracks renaming weighted_round_robin_experimental to weighted_round_robin.

See #6241 from @dfawley, which I suppose introduced it with the suffix for a reason.

@atollena atollena added the Type: Feature New features or improvements in behavior label Jul 25, 2023
@dfawley dfawley self-assigned this Jul 25, 2023
@dfawley dfawley added the P2 label Jul 25, 2023
@dfawley
Copy link
Member

dfawley commented Jul 25, 2023

The "experimental" suffix is there to allow sufficient time for testing & validation. It has passed all our internal validation, so I can remove the suffix.

@atollena
Copy link
Collaborator Author

Thanks for your answer, I just saw #6477 which I assume will land in 1.57 or 1.58.

@dfawley
Copy link
Member

dfawley commented Jul 26, 2023

Yes, I'll put this in the 1.57 release, which should happen today.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 Type: Feature New features or improvements in behavior
Projects
None yet
Development

No branches or pull requests

2 participants