grpc: re-enable channel idleness by default #6585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
approved these changes
Aug 28, 2023
dialoptions.go
Outdated
| @@ -680,8 +681,8 @@ func WithResolvers(rs ...resolver.Builder) DialOption { | |||
| // channel will exit idle mode when the Connect() method is called or when an | |||
| // RPC is initiated. | |||
| // | |||
| // By default this feature is disabled, which can also be explicitly configured | |||
| // by passing zero to this function. | |||
| // A default timeout of 30 min will be used if this dial option is not set at | |||
There was a problem hiding this comment.
Nit: "minutes" instead of "min" would be more formal / appropriate for godoc comments.
easwars
force-pushed
the
enable_idle_timeout
branch
from
41aa631
to
223379f
Compare
This was referenced Nov 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plan was always to enable this by default. But we hit a bug right after making the changes, and had to disable it. We have since fixed the underlying bug.
Fixes #6559
RELEASE NOTES:
idle_timeoutof30m