xds: fix hash policy header to skip bin headers and use extra metadata #6609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zasweq
approved these changes
Sep 7, 2023
| if len(values) == 0 { | ||
| continue | ||
| // Extra metadata takes precedence over the user's metadata. | ||
| values = md.Get(policy.HeaderName) |
There was a problem hiding this comment.
So at this point in the RPC lifecycle, the only overwriting extra metadata is "content-type"? "However, we will support matching against the content-type header; if a gRPC implementation does not add that header until after xDS route selection is done, then xDS route selection will assume a hard-coded value of application/grpc."
There was a problem hiding this comment.
Yes, the "extra metadata" is "content-type"... I'm not sure I like how this all was done (originally for route matching), but it works at least.
|
Thanks, feel free to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A42 update PR: grpc/proposal#392
Also a minor performance optimization to not read metadata from context more than once if not required, as this operation allocates a map (
grpc-go/metadata/metadata.go
Line 271 in c2b0797
RELEASE NOTES: