balancer: add a warning for balancer names that contain upper case letters #6647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like throughout this PR you've confused case sensitive & insensitive. We are currently insensitive but will be changing to become case sensitive, meaning anything registered with capitals are likely a problem (unless service config references it with capitals as well). |
|
Done. Thanks. |
dfawley
reviewed
Sep 25, 2023
| // TODO: Skip the use of strings.ToLower() to index the map after v1.59 | ||
| // is released to switch to case sensitive balancer registry. Also, | ||
| // remove this warning and update the docstrings for Register and Get. | ||
| logger.Warningf("Balancer registered with name %q. grpc-go will be switching to case sensitive balancer registries soon", b.Name()) |
There was a problem hiding this comment.
Shall we add a similar log message to Get?
dfawley
approved these changes
Sep 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the next release (v1.59), we can switch over to having a case sensitive balancer registry.
This PR also fixes a test which would be broken once we switch to a case sensitive balancer registry.
#5288
RELEASE NOTES: