internal: use OS defaults for TCP keepalive params in Windows #6863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6863 +/- ##
==========================================
- Coverage 83.75% 83.74% -0.01%
==========================================
Files 286 286
Lines 30792 30792
==========================================
- Hits 25789 25788 -1
- Misses 3948 3951 +3
+ Partials 1055 1053 -2 |
mmatczuk
force-pushed
the
mmt/tcp_keepalive_windows
branch
from
2c1be31
to
4ed7a9a
Compare
…ers.go The others file suffix is a common for such use cases.
mmatczuk
force-pushed
the
mmt/tcp_keepalive_windows
branch
from
4ed7a9a
to
ec88089
Compare
easwars
approved these changes
Dec 19, 2023
dfawley
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #6841.
This patch adds Windows support, alongside UNIX, to set TCP keepalives with OS defaults #6834.
RELEASE NOTES: